Fixed two bugs #154
Merged
Fixed two bugs #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"j.length" changed in each loop step, causing source/track nodes being left in DOM.
…Name comparison case-insensitive. It caused the issue of flash-fallback not being able to discover the source of the video and embed it into flashvars.
|
Commented on the second. |
heff
added a commit
that referenced
this pull request
Mar 21, 2012
Fixed two bugs: Removing sources with changing source count. Checking element nodeName, IE doesn't force uppercase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was integrating videojs player to my drupal site, and found these small bugs which caused the following problems:
Please review these changes.
Thanks